actions/mark
1
0
Fork 0
mirror of https://github.com/kovetskiy/mark.git synced 2026-03-14 06:07:36 +08:00
Code Issues Packages Projects Releases 1 Wiki Activity

test: restore global log level after each SetLogLevel subtest

Browse Source 
SetLogLevel mutates a process-global logger, leaking state into
subsequent tests and causing order-dependent failures. Save the
current level before each subtest and restore it via t.Cleanup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Manuel Rüger 2026-03-12 23:18:49 +01:00
parent 5e1d40d910
commit 664a99cd00
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
util/cli_test.go
View File

@ -97,6 +97,8 @@ func Test_setLogLevel(t *testing.T) {
} }
for name, tt := range tests { for name, tt := range tests {
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
prev := log.GetLevel()
t.Cleanup(func() { log.SetLevel(prev) })
cmd := &cli.Command{ cmd := &cli.Command{
Name: "test", Name: "test",
Flags: []cli.Flag{ Flags: []cli.Flag{