From 0583aaa7ce648e6ff437a4847685f79942472c71 Mon Sep 17 00:00:00 2001
From: Aldo Mateli <aldo.mateli@gmail.com>
Date: Mon, 29 Sep 2025 20:40:35 +0100
Subject: [PATCH] Strip double quotes from admonition titles

---
 renderer/mkDocsAdmonition.go |  8 ++++++--
 testdata/admonitions.html    | 10 +++++-----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/renderer/mkDocsAdmonition.go b/renderer/mkDocsAdmonition.go
index 262801d..c1080ef 100644
--- a/renderer/mkDocsAdmonition.go
+++ b/renderer/mkDocsAdmonition.go
@@ -2,6 +2,7 @@ package renderer
 
 import (
 	"fmt"
+	"strings"
 
 	parser "github.com/stefanfritsch/goldmark-admonitions"
 	"github.com/yuin/goldmark/ast"
@@ -114,8 +115,11 @@ func (r *ConfluenceMkDocsAdmonitionRenderer) renderMkDocsAdmonition(writer util.
 		if _, err := writer.Write([]byte(prefix)); err != nil {
 			return ast.WalkStop, err
 		}
-		if string(n.Title) != "" {
-			titleHTML := fmt.Sprintf("<p><strong>%s</strong></p>\n", string(n.Title))
+
+		title := strings.Trim(string(n.Title), "\"")
+
+		if title != "" {
+			titleHTML := fmt.Sprintf("<p><strong>%s</strong></p>\n", title)
 			if _, err := writer.Write([]byte(titleHTML)); err != nil {
 				return ast.WalkStop, err
 			}
diff --git a/testdata/admonitions.html b/testdata/admonitions.html
index 10e4dfa..b8434c8 100644
--- a/testdata/admonitions.html
+++ b/testdata/admonitions.html
@@ -1,7 +1,7 @@
 <h1 id="Main-Heading">Main Heading</h1>
 <h2 id="First-Heading">First Heading</h2>
 <ac:structured-macro ac:name="note"><ac:parameter ac:name="icon">true</ac:parameter><ac:rich-text-body>
-<p><strong>"NOTES:"</strong></p>
+<p><strong>NOTES:</strong></p>
 <ol>
 <li>Note number one</li>
 <li>Note number two</li>
@@ -14,7 +14,7 @@ b</p>
 </ac:rich-text-body></ac:structured-macro>
 <h2 id="Second-Heading">Second Heading</h2>
 <ac:structured-macro ac:name="warning"><ac:parameter ac:name="icon">true</ac:parameter><ac:rich-text-body>
-<p><strong>"Warn"</strong></p>
+<p><strong>Warn</strong></p>
 <ul>
 <li>Warn bullet 1</li>
 <li>Warn bullet 2</li>
@@ -30,7 +30,7 @@ that runs long</li>
 </ac:rich-text-body></ac:structured-macro>
 <h2 id="Fourth-Heading---Warn-should-not-get-picked-as-block-quote">Fourth Heading - Warn should not get picked as block quote</h2>
 <ac:structured-macro ac:name="tip"><ac:parameter ac:name="icon">true</ac:parameter><ac:rich-text-body>
-<p><strong>"TIP:"</strong></p>
+<p><strong>TIP:</strong></p>
 <ol>
 <li>Note number one</li>
 <li>Note number two</li>
@@ -69,14 +69,14 @@ b</p>
 </ac:rich-text-body></ac:structured-macro>
 <h3 id="Important/Caution-Type-Alert-Heading">Important/Caution Type Alert Heading</h3>
 <ac:structured-macro ac:name="info"><ac:parameter ac:name="icon">true</ac:parameter><ac:rich-text-body>
-<p><strong>"[!IMPORTANT]"</strong></p>
+<p><strong>[!IMPORTANT]</strong></p>
 <ul>
 <li>Important bullet 1</li>
 <li>Important bullet 2</li>
 </ul>
 </ac:rich-text-body></ac:structured-macro>
 <ac:structured-macro ac:name="warning"><ac:parameter ac:name="icon">true</ac:parameter><ac:rich-text-body>
-<p><strong>"[!CAUTION]"</strong></p>
+<p><strong>[!CAUTION]</strong></p>
 <ul>
 <li>Important bullet 1</li>
 <li>Important bullet 2</li>